Unable to type in Chinese in integrated terminal

[Racaly]

Issue Type: Bug

打开内置终端 无法输入中文，

VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: enabled rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.86GB (11.40GB free)
Process Argv	--crash-reporter-id f85a41a1-239d-4bd7-a4a1-dc3c12e2b6be
Screen Reader	no
VM	0%

Extensions (6)

Extension	Author (truncated)	Version
vscode-eslint	dba	2.1.14
vsc-material-theme	Equ	33.1.2
vsc-material-theme-icons	equ	1.2.2
git-graph	mhu	1.28.0
vscode-language-pack-zh-hans	MS-	1.53.2
vetur	oct	0.32.0

(1 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt600cf:30251589

[rebornix]

I can reproduce:

[rebornix]

It's not new, I can reproduce this on both 1.52 and 1.51 (didn't try to find a working one). xterm.js in browser works fine.

[heartacker]

me too

[zhao-kang]

me too

[lianjy357]

The terminal can't input Chinese characters, but the CMD in Windows system can input Chinese normally. The installed version is 1.53. How can I input Chinese

[gitlixingwei]

+1

[ZhouBox]

+10086

[longshihui]

+100000086

[Python-37]

I met same bug, I found that Windows builtin input method can use normally, some other input methods cannot input Chinese. When I met this bug, I thought that it's because of the input method I am using. BTW, VS Code in GNU/Linux works normally too.

[Kingwl]

It's not only Chinese but also Japanese, Thai, Kazakh, Russian, etc. Even emoji (paste).

I guess this may caused by unicode.

[longshihui]

We can review they commits on version 1.52 -> 1.53

[Kingwl]

We can review they commits on version 1.52 -> 1.53

According to rime/weasel#605 (comment), There are to many commits after 1.51. We may not able to review them.

[longshihui]

I met same bug, I found that Windows builtin input method can use normally, some other input methods cannot input Chinese. When I met this bug, I thought that it's because of the input method I am using. BTW, VS Code in GNU/Linux works normally too.

Thanks your reply, I try windows native input methods, it works!

[ChaoQunPeng]

I have this problem too. My version is 1.53.But what I have found so far is that the QQ input method and the Microsoft input method can input Chinese, while the sogou input method cannot input Chinese.

[Kingwl]

After some shallow track.

Seems caused by xterm.paste

[longshihui]

最好的办法还是切换输入法，插件会自动升级，旧版本的VSCode上插件会出现不可用的情况，例如Vetur

[ccloli]

So, the final solution is switch to QQ pinyin or Rime, and do these changes? #115814 (comment)

@Python-37 Yes but not exactly, that's just a solution, I don't want to spend time on it for now since I'm still having works to do. At least, for common users, you can try these options, and for advanced users, you can build it by yourself and revert the broken commit (or just use my compiled binary, but I'm not supposed to update it).

---

BTW, I tried to run Xterm in Edge, a "real" browser, and it's fun that at this time, Sogou Pinyin fires all the events we needed, and Xterm works well. But Baidu IME is still not working, just the same as in Electron.

Edge-KeyboardEvent.mp4

Edge-CompositionEvent.mp4

Browser	Events	Sogou Pinyin	Baidu Pinyin	Microsoft Pinyin	Rime (Weasel)	QQ Pinyin	QQ Pinyin (SL)
Electron 9	KeyboardEvent	🔺	🔺	✔	✔	✔	✔
	CompositionEvent	✖	✖	✔	✔	✔	✔
	Value up-on-date	✖	✖	✔	✖	✖	✔
	Xterm Working	✔	✔	✔	✖	✖	✔
Electron 12	KeyboardEvent	✖	✖	✔	✔	✔	✔
	CompositionEvent	✖	✖	✔	✔	✔	✔
	Value up-on-date	✖	✖	✔	✖	✖	✔
	Xterm Working	✖	✖	✔	✖	✖	✔
Edge	KeyboardEvent	✔	✖	✔	✔	✔	✔
	CompositionEvent	✔	✖	✔	✔	✔	✔
	Value up-on-date	✔	✖	✔	✖	✖	✔
	Xterm Working	✔	✖	✔	✖	✖	✔

• KeyboardEvent: ✖ Only keyup | 🔺 Only keyup on input, but will fire keydown when completed | ✔ All events
• CompositionEvent: ✖ No events | ✔ All events
• Value up-on-date: ✖ Won't update UI input value in realtime when inputing | ✔ Will update UI input value in realtime
• QQ Pinyin (Single-line mode) behaves more like Microsoft Pinyin
• QQ Pinyin and Weasel are not working is mostly because of a css style issue

So I guess Sogou Pinyin maintains a list to determine which mode will be used for specific program, since when using Edge, its behavior is more like Microsoft Pinyin.

So at this time, I think (besides the css style problem) it's Sogou Pinyin and Baidu IME's fault. 🤔

[longshihui]

Today，Sogou Pinyin is work! maybe Sogou Pinyin updated? My VSCode version is 1.54.1

[ccloli]

Today，Sogou Pinyin is work! maybe Sogou Pinyin updated? My VSCode version is 1.54.1

@longshihui Yep, so as I said in previous comment, Sogou Pinyin maintains a list that configuring use which mode for specific programs, and it has some hot-update today that changes working mode for VSCode. Though I guess it only matches released VSCode, since Code OSS, VSCode Insider and Electron are still not working.

Sogou-behavior-20210310.mp4

[wyattzheng]

@longshihui
still not working for me, same as your vscode's version.

[ccloli]

@ZhyMC Restart your computer and retry. I reverted my VM to yesterday's snapshot, and disconnect the network, then I still get the hotfix, so maybe the hotfix is patched yesterday and it'll be apply on your next reboot.

BTW as I mentioned, the hotfix only applies to released stable VSCode, and seems that it's done by matching process execution name. If I rename Code.exe to Code-1.exe, it's broken again. 🤣

[wyattzheng]

@ccloli
I have restarted my computer twice and found it's still not working (it's totally a released stable version which i downloaded from the vscode's official website).

But to my another computer in my workspace. It works!
So the existence of hotfix is proved.
As what you described, sogou maintains a list. that's incredible.

[lianjy357]

搜狗输入法可以输入了。搜狗热更新了，搜狗接锅。

[wyattzheng]

what's more interesting, the tech support of sogou think that it's vscode's issue.
but they admitted that they have released a hotfix.🤣

[yangtianfu01]

搜狗输入法可以输入了。搜狗热更新了，搜狗接锅。

屁咧哈哈哈他们把官网的10.1版本回滚了, 现在套着个10.x的皮, 安装出来的确是8.8正式版.

我试了其他家的输入法,都没问题(QQ拼音, 百度输入法), 只有搜狗没办法在终端输入中文;

20210311
诶!问题解决了!
终端可以输入中文了!
(安装完, 重启电脑后, 搜狗会更新到10.x版本)

[Python-37]

屁咧哈哈哈他们把官网的10.1版本回滚了, 现在套着个10.x的皮, 安装出来的确是8.8正式版.

I don't think they could roll back the version of their software because of a bug only encountered in the programmer community.

[wyattzheng]

maybe they just dont want to update the installer. and make autoupdate in the users' machine.

[longshihui]

hot update is nb

[Lxshmily]

可以可以，刚更新了vscode，1.54.2，

[Python-37]

Rime users can try this.
rime/weasel#605 (comment)

[hqzh]

1.54.3 worked

[Tyriar]

I've merged in the fix from xterm.js, thanks all! Please try out insiders on Monday to verify it works.

[ccloli]

I've merged in the fix from xterm.js, thanks all! Please try out insiders on Monday to verify it works.

Checked and confirmed that both QQ Pinyin and Rime (Weasel) work fine on today's Insider build.

[Python-37]

I've merged in the fix from xterm.js, thanks all! Please try out insiders on Monday to verify it works.

I've checked with Rime IME, Rime works fine in the latest insider release, and I've closed the issue in rime/weasel#605, nice work.

[Tyriar]

@Python-37 I did very little 😅 all thanks should go to you and the others that helped investigate ❤️