Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a configuration object when creating terminals via API #11332

Closed
Tyriar opened this issue Aug 31, 2016 · 4 comments
Closed

Use a configuration object when creating terminals via API #11332

Tyriar opened this issue Aug 31, 2016 · 4 comments
Assignees
@Tyriar
Labels
api debt Code quality issues terminal General terminal issues that don't fall under another label

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 31, 2016

In order to avoid issues with parameter order and addition options in the future, factor out the terminal configuration and use that in window.createTerminal (similar to the config object used in setLanguageConfiguration).

Old: createTerminal(name?: string): Terminal
New: createTerminal(configuration: TerminalConfiguration): Terminal

FYI @jrieken
@Tyriar Tyriar added api debt Code quality issues terminal General terminal issues that don't fall under another label labels Aug 31, 2016
@Tyriar Tyriar added this to the August 2016 milestone Aug 31, 2016
@Tyriar Tyriar self-assigned this Aug 31, 2016
@Tyriar Tyriar closed this as completed in 873b3d0 Aug 31, 2016
Tyriar added a commit to Tyriar/vscode-terminal-api-example that referenced this issue Aug 31, 2016
@Tyriar
Use TerminalConfiguration object in createTerminal
aa1db9c 
See microsoft/vscode#11332
@jrieken jrieken reopened this Sep 1, 2016
@jrieken
Copy link
Member

jrieken commented Sep 1, 2016 •
edited
Loading

No - we don't go complex first but handle the situation (with an overload) if the need ever arises.

@Tyriar Tyriar mentioned this issue Sep 1, 2016
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2016

The need has arisen, a shell path will need to be added for this to be useful for a lot of people #10917. See #11214 (comment)

@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2016

Another one #11384

@Tyriar
Copy link
Member Author

Tyriar commented Sep 1, 2016

Reverted in 7bd499a

@Tyriar Tyriar closed this as completed Sep 1, 2016
@Tyriar Tyriar removed this from the August 2016 milestone Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api debt Code quality issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrieken @Tyriar