Apple Silicon: error with keychain

[ItalyPaleAle]

Version: 1.52.0-exploration
Commit: 88c7381
Date: 2020-11-20T09:15:28.497Z (4 days ago)
Electron: 11.0.2
Chrome: 87.0.4280.67
Node.js: 12.18.3
V8: 8.7.220.25-electron.0
OS: Darwin arm64 20.1.0

Steps to Reproduce:

1. On a fresh install, enable settings sync (using the Stable channel)
2. Sign in with a GitHub account
3. After logging in on the browser, go back to VS Code Exploration
4. The error below appears:
   

Despite the error, settings to start syncing. And then the window crash multiple times... until it works! (probably connected to #111091?)

Does this issue occur when all extensions are disabled?: Fresh install w/ no extensions

[deepak1556]

Oh weird the keytar module is built for x64, looks like cross-compiling didn't work.

[deepak1556]

I am currently using electron-prebuild to cross-compile native modules, and it looks like the package doesn't rebuild prebuilt modules from source https://github.com/electron/electron-rebuild/blob/master/src/module-rebuilder.ts#L296. Keytar is the only prebuilt module we have now, I will add a separate rebuild step for it.

[roblourens]

@deepak you will probably have to verify this one yourself...

[ItalyPaleAle]

@roblourens I can confirm that it is working on the latest Exploration build

[roblourens]

Thanks!