Crash when reloading window on M1 Mac

[kynrai]

Issue Type: Bug

Install latest insiders build on apple silicon mac, download and apply github theme dark, this causes a crash.
Same thing happens with if install and apply the material icon pack

VS Code version: Code - Exploration 1.52.0-exploration (88c7381, 2020-11-20T09:15:28.497Z)
OS version: Darwin arm64 20.1.0

System Info

Item	Value
CPUs	undefined
GPU Status	2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	1, 1, 1
Memory (System)	16.00GB (0.35GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (2)

Extension	Author (truncated)	Version
go	gol	0.18.1
material-icon-theme	PKi	4.4.0

(1 theme extensions excluded)

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221882
python763:30178808
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
python504:30227505
vswsl492:30208929
wsl2prompt:30219162
vstry244:30226747
pythonvsdeb440:30224570
unusedprompt:30219164
folderexplorercf:30219167
openfilemenucf:30219169
pythonvsded773:30223139

[kynrai]

An easier way to trigger likely the same crash is to cause a auto UI reload, for example change the settings editor mode from ui->json and that causes a reload which crashes the window

[deepak1556]

Can you start with --crash-reporter-directory /tmp/vscode-crash and attach the generated dmp files when crash happens.

[kynrai]

Interestingly I cannot cause this to crash any longer with all my previous steps to generate the crash report, Ive not changed any other settings but something has stabilised it. If anyone else gets this issue maybe they can post a crash report, ill keep trying though

[ItalyPaleAle]

This seems to be happening to me when extensions are installed that could cause the window to reload. For example, after enabling settings sync for the first time (so my extensions are re-installed) or after connecting to a new Remote Container, when new extensions need to be re-installed.

[deepak1556]

I will merge this to #106770, all the known crash paths should be fixed in the next release