Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable multiple selection in tags #111095

Closed
TicTak21 opened this issue Nov 21, 2020 · 9 comments
Closed

Disable multiple selection in tags #111095

TicTak21 opened this issue Nov 21, 2020 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@TicTak21
Copy link

TicTak21 commented Nov 21, 2020

  • VSCode Version: 1.52.0-insider
  • Commit: caf01ba
  • Date: 2020-11-20T07:35:38.417Z (1 day ago)
  • Electron: 9.3.3
  • Chrome: 83.0.4103.122
  • Node.js: 12.14.1
  • V8: 8.3.110.13-electron.0
  • OS: MacOS Darwin x64 19.6.0

After the last few updates I noticed a strange problem/bug.

Steps to Reproduce(screenshots below):

  1. Select any tag
  2. Change selected tag(they will turn red)
  3. All tags with similar name will changes

1, 2)
Screenshot 2020-11-21 at 15 26 52

Screenshot 2020-11-21 at 15 27 21

Expected behaviour:

Only selected tag and closing tag will be renamed. ONLY without next tag.

Does this issue occur when all extensions are disabled?: Yes

How can I disable/fix this issue. Its very annoying when all tags with similar name will be renamed.
Maybe it related to this issue? #110983

@vscodebot
Copy link

vscodebot bot commented Nov 21, 2020

@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2020

That's in a TypeScript / JavaScript React, right?

@aeschli aeschli assigned jrieken and unassigned aeschli Nov 23, 2020
@TicTak21
Copy link
Author

Yes.
Typescript + React.

@jrieken jrieken added the info-needed Issue requires more information from poster label Nov 24, 2020
@jrieken
Copy link
Member

jrieken commented Nov 24, 2020

Please share the file you are seeing this with

@TicTak21
Copy link
Author

Header.tsx.zip

@jrieken
Copy link
Member

jrieken commented Nov 24, 2020

fyi - just disable onTypeRename (for TS only) and this stops

@jrieken
Copy link
Member

jrieken commented Nov 24, 2020

fyi @mjbvz tsx/jsx tag rename seems to be (partially) working as tsserver reports some of them as const

@TicTak21
Copy link
Author

TicTak21 commented Nov 24, 2020

"[typescriptreact]": {
    "editor.renameOnType": false
  },

works for me

@jrieken
Copy link
Member

jrieken commented Nov 24, 2020

Closing this as the feature works as designed. Tho it might be unexpected in some cases...

@jrieken jrieken closed this as completed Nov 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants