editor.renameOnType causes unwanted renaming outside of HTML tags

[DanielHZhang]

Version: 1.52.0-insider (user setup)
Commit: a36c68b
Date: 2020-11-19T05:37:52.577Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042
WSL2
Remote-WSL: 0.51.3

Steps to Reproduce:

1. Enable "editor.renameOnType": true in settings.
2. Create a Typescript file with the contents below:

function foo(object: Record<string, any>): void {
  const bar = '';
  if (bar === '') {
    bar.toLowerCase();
  }
  
}

3. Put the cursor on line 6 and type bar.
4. Wait momentarily for the renameOnType handler to select all occurrences of bar.
5. Backspace bar on line 6.

Expected:
Only bar on line 6 is deleted, as it is not an HTML tag.

Issue:
All instances of bar are deleted.

See:

Does this issue occur when all extensions are disabled?: Yes

[napei]

Am experiencing something similar, but more annoyingly in Typescript with this which makes it disappear from pretty much everywhere in the document.

[tlgreg]

Same with typescript generic types.

[jrieken]

That's how the feature is meant to work and you should be using "editor.renameOnType": false then

[IllusionMH]

@jrieken in JS rename on type will be very useful in the same way as in HTML - edit JSX tags.
If I put

// "[typescript]" or
"[javascript]": { 
    "editor.renameOnType": false
}

it obviously disables it in all areas and won't be possible in JSX as well.
Are there plans to have option to disable them in regular code (mostly hurts + problems with 1 character generic types in TS) but leave available for JSX microsoft/TypeScript#51832 ?

[jrieken]

We will nuke the current TS implementation and rework the API and setting. This isn't about rename (in the sense of the rename refactoring) but about "linked cursors". See #109923 (comment) as related discussion. E.g the isn't really a language feature but merely an editor feature

[IllusionMH]

We will nuke the current TS implementation and rework the API and setting

@jrieken thank you for clarification. Will look for new implementation/settings, in the meantime will disable it for specific languages.