Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Do not reach to Marketplace if extension is already installed unless forced #110905

Closed
sandy081 opened this issue Nov 19, 2020 · 1 comment
Closed

CLI: Do not reach to Marketplace if extension is already installed unless forced #110905

sandy081 opened this issue Nov 19, 2020 · 1 comment
Assignees
@sandy081
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders perf verification-needed Verification of issue is requested verified Verification succeeded workbench-cli VS Code Command line issues
Milestone
November 2020

Comments

@sandy081
Copy link
Member

While installing an extension from CLI, if an extension is already installed, CLI reached to Marketplace to check if there is a newer version or not and prints following message:

Extension '<extension-id>' v0.20.0 is already installed, but a newer version 0.21.0 is available in the marketplace. Use '--force' option to update to newer version.

Though informative, it is not necessary and makes the operation slower. At the end --force flag has to be passed to forcefully install/update.

To make it faster, do not reach to Marketplace if extension is already installed. Check and install updates only when --force flag is passed.
@sandy081 sandy081 added extensions Issues concerning extensions perf workbench-cli VS Code Command line issues labels Nov 19, 2020
@sandy081 sandy081 added this to the November 2020 milestone Nov 19, 2020
@sandy081 sandy081 self-assigned this Nov 19, 2020
@sandy081
Copy link
Member Author

sandy081 commented Nov 19, 2020 •
edited
Loading

If extension is already installed and if --force flag is not passed, then following message is printed.

Extension '<extension-id>' is already installed. Use '--force' option to check and update to newer version.

If --force flag is passed, updates are checked and installed automatically.

sandy081 added a commit that referenced this issue Nov 19, 2020
@sandy081
#110905 also optimise for builtin extensions arg
145c6e5
chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@sandy081
Fix microsoft#110905
b34ba49
chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@sandy081
microsoft#110905 also optimise for builtin extensions arg
8121828
@sandy081 sandy081 added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Nov 30, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders perf verification-needed Verification of issue is requested verified Verification succeeded workbench-cli VS Code Command line issues
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
3 participants
@rzhao271 @sandy081 and others