Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] Files served by readonly filesystem show double '(read-only)' suffix in titlebar again #109733

Closed
gjsjohnmurray opened this issue Oct 30, 2020 · 4 comments
Closed

[regression] Files served by readonly filesystem show double '(read-only)' suffix in titlebar again #109733

gjsjohnmurray opened this issue Oct 30, 2020 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone
November 2020

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

image

Previously logged as #79240 and fixed in #79241.

Repro steps are as given in previous issue.

Regression apparently occurred in 12cf39d

I will submit a PR.

VS Code version: Code 1.50.1 (d2e414d, 2020-10-13T15:06:15.712Z)
OS version: Windows_NT x64 10.0.18363
@bpasero bpasero self-assigned this Oct 30, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities workbench-editors Managing of editor widgets in workbench window labels Oct 30, 2020
@bpasero bpasero added this to the November 2020 milestone Oct 30, 2020
@bpasero
Copy link
Member

bpasero commented Oct 30, 2020

Thanks, seems to reproduce in stable already. Open for grab.

@gjsjohnmurray
Copy link
Contributor Author

Thanks, seems to reproduce in stable already. Open for grab.

@bpasero PR incoming shortly from me.

gjsjohnmurray added a commit to gjsjohnmurray/vscode that referenced this issue Oct 30, 2020
@gjsjohnmurray
fix microsoft#109733 prevent double '(read-only)' suffix in titlebar
258bce1
@gjsjohnmurray gjsjohnmurray mentioned this issue Oct 30, 2020
Closed
bpasero added a commit that referenced this issue Oct 31, 2020
@bpasero
[regression] Files served by readonly filesystem show double '(read-o…
cfb74bd 
…nly)' suffix in titlebar again (fix #109733)
@bpasero bpasero closed this as completed in d6c2656 Nov 2, 2020
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Nov 9, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

This bug has been fixed in to the latest release of VS Code Insiders!

@gjsjohnmurray, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 24b28f5 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@gjsjohnmurray
Copy link
Contributor Author

/verified

@bpasero bpasero added the verified Verification succeeded label Nov 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
November 2020
Development

Successfully merging a pull request may close this issue.

fix #109733 prevent double '(read-only)' suffix in titlebar gjsjohnmurray/vscode
3 participants
@bpasero @gjsjohnmurray and others