Extensions with a onDebugDynamicConfigurations are eagerly activated at startup in v1.50

[DanTup]

In 1.50, any extension that has onDebugDynamicConfigurations in its activation events is immediately activated when opening any project loading VS Code. This did not happen in v1.49.

[2020-10-13 10:37:47.815] [exthost] [info] ExtensionService#_doActivateExtension Dart-Code.dart-code {"startup":false,"extensionId":{"value":"Dart-Code.dart-code","_lower":"dart-code.dart-code"},"activationEvent":"onDebugDynamicConfigurations"}

There's some discussion around this in #96297 / #88230 and my understanding is that they should not be activated so early. This leads to other issues such as language extensions spawning their language servers for every project (whether they should is another issue - but there's no guidance from VS Code on how they should handle this, especially without knowing why they were activated).

[weinand]

@isidorn IIRC, we have discussed the approach for avoiding early activation in #96297.

[isidorn]

@DanTup correct but we are activating only the type that is needed I assume.
Does this happen all the time, or only when a user has used a dynamic configuration from Dart and reloads the window?

If that is the case, we need to get dynamic configs on startup to be able to select the proper one.

[DanTup]

@isidorn it's worse than that - the extensions are activated unconditionally at startup of VS Code. If you install the Dart extension, click File -> Close Folder, then Reload Window you'll see Dart is immediately activated without doing anything (or even having any workspace folder open).

[isidorn]

Assigning to October to investigate more

[isidorn]

@DanTup thanks a lot for reporting this and sorry about the breakage.
I have pushed a fix for this, so please try it out with vscode insiders from tomorrow and let us know how it goes. Thanks a lot!

[DanTup]

Thanks, will do!

[DanTup]

@isidorn fix looks good to me, thanks!

[isidorn]

Great, thanks for letting us know. Adding verified label.