Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.action.closeEditorsInGroup does not close the group when tabs are disabled. #10438

Closed
cleversprocket opened this issue Aug 11, 2016 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster
Milestone

Comments

@cleversprocket
Copy link

  • VSCode Version: 1.4.0
  • OS Version: OSX 10.10.5

Steps to Reproduce:

  1. Disable Tabs by setting the rule "workbench.editor.showTabs": false in User settings settings.json and change the behavior of cmd+w by binding it to workbench.action.closeEditorsInGroup as mentioned in Stacks & Tabs: Added or changed commands #6605 in Keyboard Shortcuts keybindings.json
  2. Select a file to edit with cmd+p.
  3. Repeat step 2 with several different files.
  4. Open a new editor pane with cmd+2.
  5. Use step 2 in the new pane to open a file for editing.
  6. Repeat step 3 in the new pane.
  7. Attempt to close the new pane with cmd+w then the first pane.

Expected Results:
The pane closes using cmd+w.

Actual Results:
cmd+w does not always close the group, just the file.

@bpasero
Copy link
Member

bpasero commented Aug 12, 2016

@cleversprocket I cannot reproduce and here is the proof:

untitled

My settings:

{
    "files.autoSave": "off",
    "editor.wrappingColumn": 3000,
    "window.openFilesInNewWindow": false,
    "window.zoomLevel": 1,
    "workbench.editor.showTabs": false
}

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 12, 2016
@bpasero bpasero added this to the Backlog milestone Aug 12, 2016
@bpasero
Copy link
Member

bpasero commented Aug 16, 2016

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!

@bpasero bpasero closed this as completed Aug 16, 2016
@cleversprocket
Copy link
Author

Sorry for the late reply, I've been trying to reproduce since I reported it
but haven't. Thank for looking into it!

On Tuesday, August 16, 2016, Benjamin Pasero notifications@github.com
wrote:

A number of days has past without answer on the questions asked. I am
thereby going to close this issue to clean up our backlog of issues. Once
you can answer on the questions, the issue can be reopened again. Thanks
for understanding this process!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10438 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADRiGWYz-O9oSzZznPhxkD0QgwR2J-whks5qgXe0gaJpZM4JiVeT
.

@bpasero
Copy link
Member

bpasero commented Aug 17, 2016

When this happens again, please use Help > Toggle Developer Tools to see if something gets logged to the console.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants