Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regexp freezes VS Code when code has emoji #100134

Closed
0x00000ED opened this issue Jun 14, 2020 · 1 comment · Fixed by #100482
Closed

Regexp freezes VS Code when code has emoji #100134

0x00000ED opened this issue Jun 14, 2020 · 1 comment · Fixed by #100482
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2020

Comments

@0x00000ED
Copy link

  • VSCode Version: 1.46.0 (user setup)
  • OS Version: Windows_NT x64 10.0.19041

Steps to Reproduce:

  1. Open editor.
  2. Create new file.
  3. Press win+; select any emoji.
  4. Open search panel and select regexp mode.
  5. Type /* in search line.
  6. RIP.

Does this issue occur when all extensions are disabled?: Yes
@IllusionMH
Copy link
Contributor

Problem here that /* or even a* will match empty string after each character.
As workaround /+ can be used to avoid ton of zero-length matches.

(Initial response removed because it had wrong conclusions.)

This was referenced Jun 17, 2020
Closed
Merged
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues editor-find Editor find operations labels Jun 22, 2020
alexdima pushed a commit that referenced this issue Jun 22, 2020
@IllusionMH
Step over surrogate pairs on zero-lenth matches (fixes #100134)
206c06b
alexdima added a commit that referenced this issue Jun 22, 2020
@alexdima
Merge pull request #100482 from IllusionMH/search-step-over-surrogate…
60da9d8 
…s-100134

Step over surrogate pairs on zero-lenth matches (fixes #100134)
@alexdima alexdima added this to the June 2020 milestone Jun 22, 2020
@lramos15 lramos15 added the verified Verification succeeded label Jun 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Step over surrogate pairs on zero-lenth matches (fixes #100134) IllusionMH/vscode
5 participants
@IllusionMH @lramos15 @alexdima @0x00000ED and others