Show lightbulb when user makes a selection in js/ts

microsoft · Sep 10, 2021 · ad67ad4 · ad67ad4
1 parent 74989b2
commit ad67ad4
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/extensions/typescript-language-features/src/languageFeatures/refactor.ts b/extensions/typescript-language-features/src/languageFeatures/refactor.ts
@@ -284,7 +284,7 @@ class TypeScriptRefactorProvider implements vscode.CodeActionProvider<TsCodeActi
 		context: vscode.CodeActionContext,
 		token: vscode.CancellationToken
 	): Promise<TsCodeAction[] | undefined> {
-		if (!this.shouldTrigger(context)) {
+		if (!this.shouldTrigger(context, rangeOrSelection)) {
 			return undefined;
 		}
 		if (!this.client.toOpenedFilePath(document)) {
@@ -386,12 +386,14 @@ class TypeScriptRefactorProvider implements vscode.CodeActionProvider<TsCodeActi
 		return codeAction;
 	}
 
-	private shouldTrigger(context: vscode.CodeActionContext) {
+	private shouldTrigger(context: vscode.CodeActionContext, rangeOrSelection: vscode.Range | vscode.Selection) {
 		if (context.only && !vscode.CodeActionKind.Refactor.contains(context.only)) {
 			return false;
 		}
-
-		return context.triggerKind === vscode.CodeActionTriggerKind.Invoke;
+		if (context.triggerKind === vscode.CodeActionTriggerKind.Invoke) {
+			return true;
+		}
+		return rangeOrSelection instanceof vscode.Selection;
 	}
 
 	private static getKind(refactor: Proto.RefactorActionInfo) {