Skip to content

Commit

Permalink
Kill ripgrep process when file search is cancelled.
Browse files Browse the repository at this point in the history
Previously we only cancelled the part of the search that happens in our process, not the actual rg process.
Fix #135936
  • Loading branch information
roblourens committed Nov 3, 2021
1 parent 86cc0a8 commit a865bed
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/vs/workbench/services/search/node/fileSearch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ export class FileWalker {

cancel(): void {
this.isCanceled = true;
killCmds.forEach(cmd => cmd());
}

walk(folderQueries: IFolderQuery[], extraFiles: URI[], onResult: (result: IRawFileMatch) => void, onMessage: (message: IProgressMessage) => void, done: (error: Error | null, isLimitHit: boolean) => void): void {
Expand Down

0 comments on commit a865bed

Please sign in to comment.