Skip to content

Commit

Permalink
Finalize TerminalOptions.runInBackground API
Browse files Browse the repository at this point in the history
Fixes #75278
  • Loading branch information
Tyriar committed Jun 11, 2019
1 parent 94b23bc commit a004864
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
9 changes: 9 additions & 0 deletions src/vs/vscode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6988,6 +6988,15 @@ declare module 'vscode' {
* must be provided as nothing will be inherited from the process or any configuration.
*/
strictEnv?: boolean;

/**
* When enabled the terminal will run the process as normal but not be surfaced to the user
* until `Terminal.show` is called. The typical usage for this is when you need to run
* something that may need interactivity but only want to tell the user about it when
* interaction is needed. Note that the terminals will still be exposed to all extensions
* as normal.
*/
runInBackground?: boolean;
}

/**
Expand Down
11 changes: 0 additions & 11 deletions src/vs/vscode.proposed.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1084,17 +1084,6 @@ declare module 'vscode' {

//#region Terminal

export interface TerminalOptions {
/**
* When enabled the terminal will run the process as normal but not be surfaced to the user
* until `Terminal.show` is called. The typical usage for this is when you need to run
* something that may need interactivity but only want to tell the user about it when
* interaction is needed. Note that the terminals will still be exposed to all extensions
* as normal.
*/
runInBackground?: boolean;
}

/**
* An [event](#Event) which fires when a [Terminal](#Terminal)'s dimensions change.
*/
Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/api/node/extHost.api.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,6 @@ export function createApiFactory(
},
createTerminal(nameOrOptions?: vscode.TerminalOptions | string, shellPath?: string, shellArgs?: string[] | string): vscode.Terminal {
if (typeof nameOrOptions === 'object') {
nameOrOptions.runInBackground = nameOrOptions.runInBackground && extension.enableProposedApi;
return extHostTerminalService.createTerminalFromOptions(nameOrOptions);
}
return extHostTerminalService.createTerminal(<string>nameOrOptions, shellPath, shellArgs);
Expand Down

0 comments on commit a004864

Please sign in to comment.