Skip to content

Commit

Permalink
Merge pull request #80135 from microsoft/roblou/80134
Browse files Browse the repository at this point in the history
Editor service requires strongly typed options
  • Loading branch information
roblourens authored Aug 30, 2019
2 parents dcc0185 + 44e5859 commit 5ab84ce
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export class PreferencesService extends Disposable implements IPreferencesServic

private openSettings2(options?: ISettingsEditorOptions): Promise<IEditor> {
const input = this.settingsEditor2Input;
return this.editorService.openEditor(input, options)
return this.editorService.openEditor(input, options ? SettingsEditorOptions.create(options) : undefined)
.then(() => this.editorGroupService.activeGroup.activeControl!);
}

Expand Down

0 comments on commit 5ab84ce

Please sign in to comment.