dispose terminal hint decoration on config change (#214178)

src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts

@@ -146,19 +146,24 @@ export class TerminalInitialHintContribution extends Disposable implements ITerm
 				marker,
 				x: this._xterm.raw.buffer.active.cursorX + 1,
 			});
+			if (this._decoration) {
+				this._register(this._decoration);
+			}
 		}
 
-		this._register(this._xterm.raw.onKey(() => {
-			this._decoration?.dispose();
-			this._addon?.dispose();
+		this._register(this._xterm.raw.onKey(() => this.dispose()));
+
+		this._register(this._configurationService.onDidChangeConfiguration(e => {
+			if (e.affectsConfiguration(TerminalInitialHintSettingId.Enabled) && !this._configurationService.getValue(TerminalInitialHintSettingId.Enabled)) {
+				this.dispose();
+			}
 		}));
 
 		const inputModel = commandDetectionCapability.promptInputModel;
 		if (inputModel) {
 			this._register(inputModel.onDidChangeInput(() => {
 				if (inputModel.value) {
-					this._decoration?.dispose();
-					this._addon?.dispose();
+					this.dispose();
 				}
 			}));
 		}