Switch from setupCustomHover to hoverService

Ref #159088 By switching to hoverService, we get to customize the hover widget more for the Settings editor indicators.
microsoft · Nov 16, 2022 · 10fe16b · 10fe16b
1 parent 04ef3da
commit 10fe16b
Show file tree

Hide file tree

Showing 4 changed files with 143 additions and 102 deletions.
diff --git a/src/vs/base/common/async.ts b/src/vs/base/common/async.ts
@@ -819,7 +819,7 @@ export class IntervalTimer implements IDisposable {
 	}
 }
 
-export class RunOnceScheduler {
+export class RunOnceScheduler implements IDisposable {
 
 	protected runner: ((...args: unknown[]) => void) | null;
 

diff --git a/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css b/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css
@@ -344,6 +344,7 @@
 	overflow: hidden;
 	text-overflow: ellipsis;
 	display: inline-block; /* size to contents for hover to show context button */
+	padding-bottom: 2px; /* so that focus outlines wrap around nicely for indicators, especially ones with codicons */
 }
 
 .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-modified-indicator {
@@ -368,7 +369,7 @@
 	bottom: 23px;
 }
 
-.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label {
+.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .setting-indicators-container {
 	font-style: italic;
 }
 
@@ -379,8 +380,8 @@
 	opacity: 0.9;
 }
 
-.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-indicator:hover {
-	text-decoration: underline;
+.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .setting-indicators-container .setting-indicator {
+	padding-bottom: 2px;
 }
 
 .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title .codicon {
-Original file line number
+Diff line change
@@ Expand Up / @@ -819,7 +819,7 @@ export class IntervalTimer implements IDisposable { @@
     	}
     }
-    export class RunOnceScheduler {
+    export class RunOnceScheduler implements IDisposable {
     	protected runner: ((...args: unknown[]) => void) | null;
@@ Expand Down @@