Fix nodejs breaking change CVE-2024-27980 #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
requested changes
May 2, 2024
joaomoreno
approved these changes
May 2, 2024
| } | ||
|
|
||
| // Add quotes as commit message is passed as a single argument to the shell | ||
| return `"${sanitizedMessage}"`; |
There was a problem hiding this comment.
Make sure that explicit quotes are really necessary when using shell: true, since I didn't find any reference to that in the docs.
There was a problem hiding this comment.
With shell: false the arguments are passed directly to the executable as an array compared to shell; true for which they are pasted into the shell. To make sure that strings with spaces in them are considered as a single argument, quotes have to be added.
This was referenced May 26, 2024
This was referenced Jun 5, 2024
This was referenced Jun 19, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a nodejs breaking change related to CVE-2024-27980.
Documentation: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
fixes #969