-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: Introduce list-targets
flag
#639
Conversation
Hi @radeksimko, thanks for the PR. I'm not sure a Btw, If you'd like to help out, feel free to pick any Given this doesn't address at all the need of #625, I'll close it for now. |
I'm afraid there is some misunderstanding here. In my case I'm trying to understand what targets are available before packaging a vsix, I'm not too concerned about inspecting an existing vsix package and neither is #625 The idea was that this command could be used in a script where you just loop over each target and call |
Would you accept |
This is in our docs: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions
That completely misses the point of this feature: it's targeted for extensions which actually have different bits per target. #625 exists only for a specific use case: the WSL extension. What's the actual use case you have for this? |
We have an extension where the extension (client) code itself is and will remain cross-platform-compatible in the foreseeable future. However we would like to start bundling the language server with the extension, which itself is not written in Node.js, but in Go and hence the binaries are platform-specific. I assume there are other extensions which also utilize language servers which are also written in a language that has platform-dependent binaries. So to clarify the use case - we wouldn't just simply call |
We suggest to manually list the targeted platforms in your CI, as per our sample: https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml |
This is one way of addressing some problems outlined in #625 but more importantly make it easier for end-users to see what targets are even supported without having to look into the source code.
I'm half wondering if this is better implemented as a new subcommand?
vsce ls-targets
orvsce ls-package-targets
, I'm assuming that this would allow easier expansion with more flags later. I imagine that a--json
flag might be useful here to change the shell-friendly new-line-separated output to JSON.