fix: Revert unreliable issue linking #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has several shortcomings in its primitive approach. There are a lot more cases where you'd not want this linking to be applied. Like fixed-width code blocks for example. Fixes #375
|
|
|
Why does this require a CLA and #564 didn't? |
|
Actually, I'll rather try to implement a proper fix for this. Reverting is stupid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has several shortcomings in its primitive approach. There are a lot more cases where you'd not want this linking to be applied. Like fixed-width code blocks for example.
Fixes #375