Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions #279

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ export interface ICreateVSIXOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be instead instead of in place.

*/
useYarn?: boolean;
}

export interface IPublishOptions {
Expand Down Expand Up @@ -52,6 +57,11 @@ export interface IPublishOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before.

*/
useYarn?: boolean;
}

/**
Expand Down Expand Up @@ -93,6 +103,11 @@ export interface IPublishVSIXOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
*/
useYarn?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems broken.

}

/**
Expand Down Expand Up @@ -121,4 +136,4 @@ export function listFiles(options: IListFilesOptions = {}): Promise<string[]> {
*/
export function publishVSIX(packagePath: string, options: IPublishVSIXOptions = {}): Promise<any> {
return _publish({ packagePath, ...options });
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line.