Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in option hint #1046

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix typo in option hint #1046

merged 1 commit into from
Sep 3, 2024

Conversation

mlasson
Copy link
Contributor

@mlasson mlasson commented Sep 3, 2024

Description

vsce package --help shows

Usage: vsce package|pack [options] [version]

Packages an extension

Options:
  -o, --out <path>                Output .vsix extension file to <path> location (defaults to <name>-<version>.vsix)
...
  --allow-missing-repository      Allow missing a repository URL in package.json
  --allow-unused-files-pattern    Allow include patterns for the files field in package.json that does not match any file
...

But the errors messages says:

The following include patterns in the "files" property in package.json do not match any files packaged in the extension:
  - LICENSE
Remove any include pattern which is not needed.

=> Run vsce ls --tree to see all included files.
=> Use --allow-unused-files-patterns to skip this check

This PR propoes to remove the "s" from the error message (because adding an s to the option would be a breaking change).

@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 3, 2024
@benibenj benibenj merged commit 3090717 into microsoft:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants