Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support signing related features #993

Closed
sandy081 opened this issue Jun 7, 2024 · 3 comments · Fixed by #994
Closed

Support signing related features #993

sandy081 opened this issue Jun 7, 2024 · 3 comments · Fixed by #994
Assignees
@sandy081
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2024

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 7, 2024

Support following signing related features

  • Generate the extension manifest from the extension vsix: vsce generate-manifest --packagePath <package-path> --out <manifest-output-path>
  • Publish the extension with signed manifest: vsce publish --packagePath <package-path> --manifestPath <manifest-path> --signaturePath <signature-path>
@sandy081 sandy081 added the feature-request Request for new features or functionality label Jun 7, 2024
@sandy081 sandy081 self-assigned this Jun 7, 2024
sandy081 added a commit that referenced this issue Jun 7, 2024
@sandy081
fix #993
957feec
@sandy081 sandy081 mentioned this issue Jun 7, 2024
Merged
@joaomoreno joaomoreno added this to the June 2024 milestone Jun 7, 2024
sandy081 added a commit that referenced this issue Jun 7, 2024
@sandy081 @joaomoreno
Support signing related features (#994)
dab8833 
* fix #993

* feedback

* Update src/main.ts

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

---------

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@connor4312 connor4312 added the verified Verification succeeded label Jun 25, 2024
@connor4312
Copy link
Member

connor4312 commented Jun 25, 2024 •
edited
Loading

@sandy081 vsce needs to be published still. Installed from main for the purposes of verification.

@connor4312
Copy link
Member

I'm not clear on how to generate the --signaturePath, the --help docs are also not super helpful (maybe signing info lives on the vscode docs eventually)

@connor4312 connor4312 added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Jun 25, 2024
@sandy081
Copy link
Member Author

@connor4312 vsce does not support signing the manifest, one has to sign the manifest separately and pass it vsce for publishing. This is limited only feature for now.

I am marking this as verified since our pipelines are successfully generating the manifest, signing it and publish them using vsce.

@sandy081 sandy081 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jun 26, 2024
@X-oss-byte X-oss-byte mentioned this issue Jul 10, 2024
Open
@sarvex sarvex mentioned this issue Jul 10, 2024
Open
This was referenced Jul 11, 2024
Open
Open
@anandgupta42 anandgupta42 mentioned this issue Jul 13, 2024
Closed
@X-oss-byte X-oss-byte mentioned this issue Jul 16, 2024
Open
@anandgupta42 anandgupta42 mentioned this issue Jul 17, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
Open
This was referenced Jul 25, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Support signing related features microsoft/vscode-vsce
4 participants
@joaomoreno @connor4312 @sandy081 @Yoyokrazy