Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository shorthand #489

Closed
cbarrick opened this issue Sep 21, 2020 · 1 comment · Fixed by #598
Closed

Repository shorthand #489

cbarrick opened this issue Sep 21, 2020 · 1 comment · Fixed by #598
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities

Comments

@cbarrick
Copy link

cbarrick commented Sep 21, 2020

With npm, package.json supports a shorthand for GitHub, GitLab, BitBucket, etc.

https://docs.npmjs.com/files/package.json#repository

However, vsce spits out a warning when one of these shorthands is used:

$ cat package.json | grep repository
    "repository": "github:foo/bar",

$ vsce package
 ERROR  Couldn't detect the repository where this extension is published. The link './LICENSE' will be broken in README.md. Please provide the repository URL in package.json or use the --baseContentUrl and --baseImagesUrl options.

It would be nice if vsce would support these shorthands.

@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Sep 24, 2020
@joaomoreno joaomoreno self-assigned this Sep 24, 2020
@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Sep 24, 2020
abhijit-hota added a commit to abhijit-hota/vscode-vsce that referenced this issue Apr 23, 2021
@wangweixuan
Copy link
Contributor

I suggest including the package hosted-git-info, which supports parsing those shorthands and is developed by npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants