Merge pull request #1011 from microsoft/benibenj/legitimate-impala

Validate publisher on package

src/package.ts

@@ -20,6 +20,7 @@ import {
 	validateVersion,
 	validateEngineCompatibility,
 	validateVSCodeTypesCompatibility,
+	validatePublisher,
 } from './validation';
 import { detectYarn, getDependencies } from './npm';
 import * as GitHost from 'hosted-git-info';
@@ -1247,6 +1248,7 @@ export class ValidationProcessor extends BaseProcessor {
 
 export function validateManifest(manifest: Manifest): Manifest {
 	validateExtensionName(manifest.name);
+	validatePublisher(manifest.publisher);
 
 	if (!manifest.version) {
 		throw new Error('Manifest missing field: version');

src/validation.ts

@@ -12,7 +12,7 @@ export function validatePublisher(publisher: string): void {
 
 	if (!nameRegex.test(publisher)) {
 		throw new Error(
-			`Invalid publisher name '${publisher}'. Expected the identifier of a publisher, not its human-friendly name.  Learn more: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions`
+			`Invalid publisher name '${publisher}'. Expected the identifier of a publisher, not its human-friendly name. Learn more: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions`
 		);
 	}
 }