Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspect.js only reads 'grammer_paths[0]' and swap replace/substr in grammer.ts #73

Merged
merged 4 commits into from
Sep 20, 2018
Merged

inspect.js only reads 'grammer_paths[0]' and swap replace/substr in grammer.ts #73

merged 4 commits into from
Sep 20, 2018

Conversation

msftrncs
Copy link
Contributor

This fixes issue #72 changing grammer_paths[0] to path in the loading for loop.

This corrects the minor issue of the weird |n| shown in the inspection at the end of some matches, which I described in #70.

@msftclas
Copy link

msftclas commented Sep 20, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@alexdima
Copy link
Member

👍 Thank you!

@alexdima alexdima merged commit 6b4f4d7 into microsoft:master Sep 20, 2018
@alexdima alexdima mentioned this pull request Sep 20, 2018
Closed
@msftrncs msftrncs deleted the msftrncs-fix branch September 21, 2018 04:00
@josecelano josecelano mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msftrncs @msftclas @alexdima