Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring #172

Merged
merged 25 commits into from
May 9, 2022
Merged

refactoring #172

merged 25 commits into from
May 9, 2022

Conversation

hediet
Copy link
Member

@hediet hediet commented May 2, 2022

No description provided.

alexdima
alexdima reviewed May 2, 2022
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. But we need some more change here to move also other .d.ts files to the release folder. Otherwise, the release/main.d.ts file can't be adopted by consumers. (this can be observed via npm run prepublishOnly)

@hediet hediet requested a review from alexdima May 9, 2022 08:59
@hediet hediet merged commit e8d1fc5 into main May 9, 2022
@hediet hediet deleted the hediet/refactoring branch May 9, 2022 13:06
@josecelano josecelano mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hediet @alexdima