Make scope capture substitution regex global #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still looking in to adding a test. |
Add the global modifier to the regex that handles scope name capture substitutions for instances where more than one substitution exists. Fixes microsoft#147
msftrncs
force-pushed
the
ScopeSubst#147
branch
from
d531b90
to
357b599
Compare
Implements a test for issue microsoft#147, to insure that multiple substitutions on a single scope specification are handled.
|
A test has been added. |
|
This is great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the global modifier to the regex that handles scope name capture substitutions for instances where more than one substitution exists.
Fixes #147