Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prompt to flip "inheritEnv" setting to false to fix conda activation issue #7633

Merged
merged 7 commits into from
Oct 2, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Sep 27, 2019

For #7607

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@karrtikr karrtikr changed the title Added prompt to flip "inheritEnv" setting to false to fix conda activation issue WIP - Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Sep 27, 2019
@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #7633 into master will increase coverage by 0.09%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7633      +/-   ##
==========================================
+ Coverage   58.72%   58.81%   +0.09%     
==========================================
  Files         494      495       +1     
  Lines       22027    22081      +54     
  Branches     3541     3552      +11     
==========================================
+ Hits        12935    12988      +53     
  Misses       8281     8281              
- Partials      811      812       +1
Impacted Files Coverage Δ
src/client/telemetry/index.ts 86.13% <ø> (ø) ⬆️
src/client/interpreter/serviceRegistry.ts 100% <100%> (ø) ⬆️
src/client/telemetry/constants.ts 100% <100%> (ø) ⬆️
src/client/common/utils/localize.ts 93.93% <100%> (+0.01%) ⬆️
...t/interpreter/virtualEnvs/condaInheritEnvPrompt.ts 98% <98%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2862614...d39e2c4. Read the comment docs.

@karrtikr karrtikr changed the title WIP - Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Added prompt to flip "inheritEnv" setting to false to fix conda activation issue Sep 30, 2019
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activate should be non blocking.

@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@ericsnowcurrently ericsnowcurrently removed their request for review October 1, 2019 18:37
@karrtikr
Copy link
Author

karrtikr commented Oct 1, 2019

Smoke UITest Linuxstable27Smoke times out😞 Maybe we should've these under CI pipeline instead of PR validation @DonJayamanne ?

@karrtikr karrtikr closed this Oct 1, 2019
@karrtikr karrtikr reopened this Oct 1, 2019
@karrtikr karrtikr merged commit e4e2fd2 into microsoft:master Oct 2, 2019
@karrtikr karrtikr deleted the inheritenv branch October 2, 2019 08:35
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants