Adding PYTHONSTARTUP with shell integration to environment variable collection #24111
Conversation
anthonykim1
added
feature-request
anthonykim1
added
skip package*.json
package.json
Outdated
| @@ -631,6 +631,12 @@ | |||
| "scope": "resource", | |||
| "type": "array" | |||
| }, | |||
| "python.terminal.enable Shell Integration in Python Terminal REPL": { | |||
There was a problem hiding this comment.
Can I get feedback on the setting name and description? @cwebster-99
This is for allowing user to opt out of using shell integration for REPL when they launch the terminal REPL via typing out "python" in terminal.
There was a problem hiding this comment.
I think this looks good. My one suggestion for the description is to be a bit more descriptive on what shell integration might enable or disable from the user perspective so users may better understand what might change in their experience.
There was a problem hiding this comment.
Thanks for the feedback! Made some changes here: 8e8dd18
So it would look like:
There was a problem hiding this comment.
debating between
Python Startup For Shell Integration
vs
Python Start up For Shell Integration
vs
PYTHONSTARTUP For Shell Integration (PYTHONSTARTUP is actual Python official name of the file we are injecting to enable the feature)
vs
Python Start Up Script
for the title
There was a problem hiding this comment.
I think I like the one that is there currently (option 1)!
Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
Resolves: #23930