Use new REPL notebook API

[amunger]

No description provided.

[anthonykim1]

Thank you for doing this - I'm giving this a try right now.
Is it expected behavior that we see the little jupyter icon next to Python REPL? @amunger

Also the format of .interactive => .ipynb of the untitled interactive file.

[anthonykim1]

similar question here - is interactive type not valid after the new REPL api?

[anthonykim1]

I've locally tested this and it seems like Intellisense is broken (not completely broken), but rather acting in weird way it doesn't provide all of the completions that it used to:

The screenshots are the Intellisense we would get before/prior this PR:

Which provides all the familiar completions from standard library module;
But after pulling in the PR into local branch I've noticed different behavior (the video is building the extension after pulling in local branch):

IntellisenseStillBroken.mov

Also one more bug finding: The very first code sent to native REPL doesn't seem to run/generate output with this PR.

[karthiknadig]

@amunger In the video you can see it updating the problems view. Should it?

[anthonykim1]

Also realized the editor name is different in the video (with changes in this PR)

Before we used to have "Python REPL" as the editor tab name like this(where you would always see Python REPL as editor tab name for native REPL instead of "REPL-1" that you see on the video above:

I think this is because before this PR, we used to run the interactive.open command and specify the editor tab name like:

const interactiveWindowObject = (await commands.executeCommand(
            'interactive.open',
            {
                preserveFocus: true,
                viewColumn: ViewColumn.Beside,
            },
            undefined,
            notebookController.id,
            'Python REPL',
        )) as { notebookEditor: NotebookEditor };

but with switching to using

openNotebookDocument

we aren't passing in the editor tab name.

This would break our logic for

vscode-python/src/client/repl/replUtils.ts

Line 99 in 63280be

if (tab.label === 'Python REPL') {

since we are relying on the editor tab name for searching.

• I think we can modify the search so that we look through all the ones with @ REPL - <some_number> but wasn't sure if this was intended.

Having just Python REPL as tab name would be nicer for now since we only allow one universal Python native REPL, but I didn't see any parameter options for openNotebookDocument to pass in editor tab name ourselves :/

[amunger]

@amunger In the video you can see it updating the problems view. Should it?

It's just another notebook cell, so it will update the problems like anything in the history of the repl would

[amunger]

The editor label is set with:const editor = window.showNotebookDocument(notebookDocument!, { viewColumn, asRepl: 'Python REPL' });, you might just need to update insiders.

I had jedi set as my language server, so I was seeing the same limited set of completions for both. I'll have to look into why pylance completions aren't working correctly.

I'm not seeing that issue with the initial cell not running, might have to debug it on your machine.

[anthonykim1]

after talking with @amunger, it seems like the issues for (intellisense, editor tab name, first command getting lost problem) were all resolved after updating vscode-insiders to the latest.
Bumping up the version number should hopefully prevent all of this happening for users.