Add Interactive REPL Experiment #23235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
reviewed
May 7, 2024
package.json
Outdated
| { | ||
| "command": "python.execInREPL", | ||
| "group": "Python", | ||
| "when": "editorFocus && editorLangId == python && !virtualWorkspace && shellExecutionSupported" |
There was a problem hiding this comment.
Does this also need “not in interactive”
?
There was a problem hiding this comment.
Is "not in interactive" referring to IW only with Jupyter?
There was a problem hiding this comment.
I think #23389 was what we were talking about??
anthonykim1
added
the
skip package*.json
amunger
reviewed
May 16, 2024
amunger
reviewed
May 16, 2024
| @@ -105,6 +108,17 @@ export function activateFeatures(ext: ExtensionState, _components: Components): | |||
| interpreterService, | |||
| pathUtils, | |||
| ); | |||
|
|
|||
| // Register native REPL context menu when in experiment | |||
| const experimentService = ext.legacyIOC.serviceContainer.get<IExperimentService>(IExperimentService); | |||
There was a problem hiding this comment.
legacy IOC? is there a newer one to use?
There was a problem hiding this comment.
Usually in other files in Python extension if we were to use serviceContainer, we access it via IServiceContainer, which we still could I believe if we register the REPL command in other file? I just thought extensionActivation was the best place to register command and read experiment service since it seemed like the fastest/prioritized when extension loads.
amunger
reviewed
May 16, 2024
src/client/repl/replCommands.ts
Outdated
| const notebookEdit = NotebookEdit.insertCells(cellCount, [notebookCellData]); | ||
| const workspaceEdit = new WorkspaceEdit(); | ||
| workspaceEdit.set(notebookDocument.uri, [notebookEdit]); | ||
| workspace.applyEdit(workspaceEdit); |
There was a problem hiding this comment.
looks like this returns a thenable, might need to await this?
There was a problem hiding this comment.
good point, just added a commit for this!
amunger
previously approved these changes
May 16, 2024
amunger
approved these changes
May 16, 2024
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
May 16, 2024
Allow users to use Interactive Window UI with Python custom REPL controller instead of iPykernel. Closes microsoft#23175 Closes microsoft#23174 Closes microsoft#23029 Majority of: microsoft#23332 Context menu under Python for running Python REPL code using IW UI should only appear when user's ```pythonRunREPL``` experiment is enabled.
This was referenced May 16, 2024
anthonykim1
added a commit
that referenced
this pull request
May 24, 2024
… UI (#23442) "Smartly" allow execute on enter for the #23235 experiment. User should be able to execute when they press enter on text input box of interactive window trigger from Python extension, whereas we would "wait" and allow insertion of new line after detecting user's Python command is not complete. When the user finally types enter again on a blank line, we should just proceed to execute whatever code, regardless of whether it is complete/valid or not to replicate Python's original interactive REPL behavior. Basically creating Python command and registering that for keybinding of 'Enter'. This would conditionally call interactive.execute which would then eventually call our execute handler contributed from Python n extension's REPL controller, or go ahead and insert,pass in Enter to the text input box to allow user to type "complete" code. This PR only intends to implement/add changes regarding execute on enter logic, adding Intellisense support, and also adding things into disposables so they can be properly disposed. Trying to also add setting to allow toggling on/off to send Python command to Terminal or IW REPL if the user is in experiment. Handling of interrupt for windows should be on separate PR. Test will be added later as separate PR. --------- Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
DonJayamanne
pushed a commit
to DonJayamanne/pythonVSCode
that referenced
this pull request
Jun 24, 2024
… UI (#23442) "Smartly" allow execute on enter for the microsoft#23235 experiment. User should be able to execute when they press enter on text input box of interactive window trigger from Python extension, whereas we would "wait" and allow insertion of new line after detecting user's Python command is not complete. When the user finally types enter again on a blank line, we should just proceed to execute whatever code, regardless of whether it is complete/valid or not to replicate Python's original interactive REPL behavior. Basically creating Python command and registering that for keybinding of 'Enter'. This would conditionally call interactive.execute which would then eventually call our execute handler contributed from Python n extension's REPL controller, or go ahead and insert,pass in Enter to the text input box to allow user to type "complete" code. This PR only intends to implement/add changes regarding execute on enter logic, adding Intellisense support, and also adding things into disposables so they can be properly disposed. Trying to also add setting to allow toggling on/off to send Python command to Terminal or IW REPL if the user is in experiment. Handling of interrupt for windows should be on separate PR. Test will be added later as separate PR. --------- Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
DonJayamanne
pushed a commit
that referenced
this pull request
Jun 24, 2024
Allow users to use Interactive Window UI with Python custom REPL controller instead of iPykernel. Closes #23175 Closes #23174 Closes #23029 Majority of: #23332 Context menu under Python for running Python REPL code using IW UI should only appear when user's ```pythonRunREPL``` experiment is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to use Interactive Window UI with Python custom REPL controller instead of iPykernel.
Closes #23175
Closes #23174
Closes #23029
Majority of: #23332
Context menu under Python for running Python REPL code using IW UI should only appear when user's
pythonRunREPLexperiment is enabled.