Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting started artwork #20065

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Update getting started artwork #20065

merged 2 commits into from
Oct 25, 2022

Conversation

daviddossett
Copy link

Fixes #20031 by...

  • Adds create-environment.svg
  • Updates python-interpreter.svg for consistency with similar core artwork
  • Uses VS Code color variables to ensure artwork reacts to theme changes
  • Removes redundant v2 artwork asset

Note that the SVG previews in the diff below don't accurately represent the illustrations since github.com can't pick up VS Code's CSS vars.

Examples

Select Interpreter

CleanShot 2022-10-25 at 12 37 21@2x

Create Environment (no walkthrough step yet)

CleanShot 2022-10-25 at 12 38 19@2x

Theme support

CleanShot.2022-10-25.at.12.41.11.mp4

@cwebster-99 cwebster-99 added the experimenting Feature is part of an experiment label Oct 25, 2022
@karthiknadig karthiknadig added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating labels Oct 25, 2022
@daviddossett daviddossett merged commit 4253600 into main Oct 25, 2022
@daviddossett daviddossett deleted the ddossett/add-artwork branch October 25, 2022 20:07
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Fixes microsoft/vscode-python#20031 by...
- Adds `create-environment.svg`
- Updates `python-interpreter.svg` for consistency with similar core
artwork
- Uses VS Code color variables to ensure artwork reacts to theme changes
- Removes redundant `v2` artwork asset

Note that the SVG previews in the diff below don't accurately represent
the illustrations since github.com can't pick up VS Code's CSS vars.

## Examples

### Select Interpreter

<img width="1143" alt="CleanShot 2022-10-25 at 12 37 21@2x"
src="https://user-images.githubusercontent.com/25163139/197867532-59d423d2-9ec0-4b5e-8b22-88916e7ff41d.png">

### Create Environment (no walkthrough step yet)

<img width="621" alt="CleanShot 2022-10-25 at 12 38 19@2x"
src="https://user-images.githubusercontent.com/25163139/197867560-d050c6a1-636a-45b2-a059-06f2ea554ac2.png">

### Theme support

https://user-images.githubusercontent.com/25163139/197867589-aaf9b93d-2900-457c-91f2-64837665fdd3.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. experimenting Feature is part of an experiment skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Environment artwork for Getting Started page
3 participants