Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all CI tests (except for debugger) are no longer allowed to fail #1942

Merged

Conversation

DonJayamanne
Copy link

Fixes #1614

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yassssss

👍

@brettcannon
Copy link
Member

Now you just need to get the tests passing again. 😉

@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 14, 2018

Looks like some of the tests are failing once again due to some upstream VS Code issue. Related to configuration settings in Multi-root workspaces.

@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4959c37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1942   +/-   ##
=========================================
  Coverage          ?   74.95%           
=========================================
  Files             ?      285           
  Lines             ?    13406           
  Branches          ?     2396           
=========================================
  Hits              ?    10048           
  Misses            ?     3226           
  Partials          ?      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4959c37...91774a9. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the issue1614DoNotLetTestsFail branch from 89e06e6 to 91774a9 Compare June 14, 2018 00:40
@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 14, 2018

Lol, tests are passing now. I'll be merging this Branch (once VSTS passes), if things start falling over we can address them separately.

@DonJayamanne DonJayamanne merged commit 749578a into microsoft:master Jun 14, 2018
@DonJayamanne DonJayamanne deleted the issue1614DoNotLetTestsFail branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A number of CI tests are failing
3 participants