Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sys.prefix workaround which is no longer needed but still validate envs #19164

Merged
merged 3 commits into from
May 19, 2022
Merged

Remove sys.prefix workaround which is no longer needed but still validate envs #19164

merged 3 commits into from
May 19, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 18, 2022 •
edited
Loading

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary labels May 18, 2022
@karrtikr karrtikr changed the title Remove sys.prefix workaround which is no longer needed Remove sys.prefix workaround which is no longer needed but still validate envs May 18, 2022
@karthiknadig karthiknadig requested a review from rchiodo May 19, 2022 00:22
@karthiknadig
Copy link
Member

@rchiodo Do you still need the sys.prefix for each environment? If I remember correctly this was used to detect the stdlib location.

@karrtikr
Copy link
Author

As mentioned in #16386 (comment), we're now getting the correct sys.prefix even without that workaround, so merging this.

@karrtikr karrtikr merged commit 8c47ced into microsoft:main May 19, 2022
@karrtikr karrtikr deleted the jfk branch May 19, 2022 16:44
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@wesm
Remove sys.prefix workaround which is no longer needed but still va…
d373d0d 
…lidate envs (microsoft/vscode-python#19164)

* Remove `sys.prefix` workaround which is no longer needed

* Validate selected interpreter

* Add/fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo Awaiting requested review from rchiodo

Assignees

@karrtikr karrtikr

Labels
no-changelog No news entry required skip tests Updates to tests unnecessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrtikr @karthiknadig