Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle numbers formatted with underscores in tokenizer #1819

Merged
merged 110 commits into from
May 31, 2018
Merged

Handle numbers formatted with underscores in tokenizer #1819

merged 110 commits into from
May 31, 2018

Conversation

MikhailArkhipov
Copy link

Fixes #1779

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@51224e7). Click here to learn what that means.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1819   +/-   ##
=========================================
  Coverage          ?   74.13%           
=========================================
  Files             ?      282           
  Lines             ?    13142           
  Branches          ?     2357           
=========================================
  Hits              ?     9743           
  Misses            ?     3267           
  Partials          ?      132
Impacted Files Coverage Δ
src/client/language/tokenizer.ts 98.01% <100%> (ø)
src/client/language/characters.ts 66.17% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51224e7...f722a03. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit 5fa57f8 into microsoft:master May 31, 2018
@MikhailArkhipov MikhailArkhipov deleted the nums branch June 7, 2018 16:35
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatOnType breaks underscore-separated numbers
2 participants