Don't add cwd
argument when running all tests
#17978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #17622 and #17898, attn: @karthiknadig.
I tested this using my example workspace with
"python.testing.cwd"
set to a sub-directory, andtestpaths
inpytest.ini
set to a sub-directory of that.Before this change, running all tests yields:
This is because the
cwd
is appended as an argument, which causes pytest to ignoretestpaths
, which causes it to collect tests that it shouldn't, causing a collection error.With this change, running all tests yields:
Note that
cwd
is no longer an argument.It looks
cwd
defaults toworkspaceFolder.fsPath
, so this seems like a safe change.