Fix handling of empty directories in debugpy wheels when combining them #17620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add filename logging when combining wheels. Update debugpy to 1.5.0.
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 4, 2021
…em. (microsoft#17620) Add filename logging when combining wheels. Update debugpy to 1.5.0.
karthiknadig
pushed a commit
that referenced
this pull request
Oct 5, 2021
…em. (#17620) Add filename logging when combining wheels. Update debugpy to 1.5.0.
|
FYI we have failing CI with this, not sure if it's related. |
|
Looks unrelated, something changed with |
karthiknadig
added a commit
that referenced
this pull request
Oct 14, 2021
* Use correct python executable when running code using Python execution factory (#17614) * pin to debugpy verion 1.4.3 * Pin debugpy (#17619) * pin to debugpy verion 1.4.3 * Pin to particular version of debugpy. * Ensure database storage extension uses to track all storages does not grow unnecessarily (#17598) * Ensure central storage to track keys for other storage never contain duplicate entries * News entry * Add tests * Add more test cases * Fix storage for function * Fix handling of empty directories in debugpy wheels when combining them. (#17620) Add filename logging when combining wheels. Update debugpy to 1.5.0. * Update news items for cherry picked. (#17624) * Pin wrapt to 1.12.1 (#17630) (#17631) * Use conda-forge when installing into conda envs (#17629) (#17632) Co-authored-by: Brett Cannon <brcan@microsoft.com> * Ensure keys whose default value type is an array are not duplicated (#17627) (#17634) * Update version and changelog for release (#17647) * Update release date in change log * Add thanks to change log. * Fix for formatting notebook cells. (#17650) * Fix for formatting notebook cells. * Ensure we check language id. * Hide walkthrough if on the web (#17638) * Log commands run by the discovery component in the output channel (#17670) * Log commands run by the discovery component in the output channel * Remove outdated comments * Ensure commands run are not logged twice in Python output channel (#17697) * Ensure commands run are not logged twice in Python output channel * News entry * Hide UI elements that are not applicable when using `github.dev` (#17698) * Hide UI elements that are not applicable when using VS Code Web * Fix indentaiton * News entry * Disable welcome view for testing * Localize strings on `github.dev` using VSCode FS API (#17711) * Change localization in the extension to be async and use the VS Code APIs * News entry * Modify error thrown * Move localization into separate module * Update news entry * Oops * Refactor so code is not duplicated * Fix tests * Oopsp * Fix lint * Provide IntelliSense status information when using `github.dev` (#17658) * Provide IntelliSense status information when using github.dev * News entry * Update wording * PR reviews * Include proposed APIs for browser config * Include common module for browser config * Change how we detect * Change wording * Have same browser config as extension config * Revert "Have same browser config as extension config" This reverts commit 515003a. * Revert "Change wording" This reverts commit dd64f24. * Revert "Change how we detect" This reverts commit ae56079. * Revert "Include common module for browser config" This reverts commit bf1815c. * Do not import from misc module * Detect how we check if property exists * Do not localize strings * Localize strings using new localize module * Remove outdated comment * Localize 'learn more' text (#17714) * Update version and change log for point release (#17717) Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Pavel Minaev <pminaev@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Brett Cannon <brcan@microsoft.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>
randomir
pushed a commit
to randomir/vscode-python
that referenced
this pull request
Mar 18, 2022
Fix handling of empty directories in debugpy wheels when combining them. (microsoft#17620) Add filename logging when combining wheels. Update debugpy to 1.5.0.
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Use correct python executable when running code using Python execution factory (microsoft/vscode-python#17614) * pin to debugpy verion 1.4.3 * Pin debugpy (microsoft/vscode-python#17619) * pin to debugpy verion 1.4.3 * Pin to particular version of debugpy. * Ensure database storage extension uses to track all storages does not grow unnecessarily (microsoft/vscode-python#17598) * Ensure central storage to track keys for other storage never contain duplicate entries * News entry * Add tests * Add more test cases * Fix storage for function * Fix handling of empty directories in debugpy wheels when combining them. (microsoft/vscode-python#17620) Add filename logging when combining wheels. Update debugpy to 1.5.0. * Update news items for cherry picked. (microsoft/vscode-python#17624) * Pin wrapt to 1.12.1 (microsoft/vscode-python#17630) (microsoft/vscode-python#17631) * Use conda-forge when installing into conda envs (microsoft/vscode-python#17629) (microsoft/vscode-python#17632) Co-authored-by: Brett Cannon <brcan@microsoft.com> * Ensure keys whose default value type is an array are not duplicated (microsoft/vscode-python#17627) (microsoft/vscode-python#17634) * Update version and changelog for release (microsoft/vscode-python#17647) * Update release date in change log * Add thanks to change log. * Fix for formatting notebook cells. (microsoft/vscode-python#17650) * Fix for formatting notebook cells. * Ensure we check language id. * Hide walkthrough if on the web (microsoft/vscode-python#17638) * Log commands run by the discovery component in the output channel (microsoft/vscode-python#17670) * Log commands run by the discovery component in the output channel * Remove outdated comments * Ensure commands run are not logged twice in Python output channel (microsoft/vscode-python#17697) * Ensure commands run are not logged twice in Python output channel * News entry * Hide UI elements that are not applicable when using `github.dev` (microsoft/vscode-python#17698) * Hide UI elements that are not applicable when using VS Code Web * Fix indentaiton * News entry * Disable welcome view for testing * Localize strings on `github.dev` using VSCode FS API (microsoft/vscode-python#17711) * Change localization in the extension to be async and use the VS Code APIs * News entry * Modify error thrown * Move localization into separate module * Update news entry * Oops * Refactor so code is not duplicated * Fix tests * Oopsp * Fix lint * Provide IntelliSense status information when using `github.dev` (microsoft/vscode-python#17658) * Provide IntelliSense status information when using github.dev * News entry * Update wording * PR reviews * Include proposed APIs for browser config * Include common module for browser config * Change how we detect * Change wording * Have same browser config as extension config * Revert "Have same browser config as extension config" This reverts commit 515003aee2fa4a44105f22c4749f1fa721be6bcf. * Revert "Change wording" This reverts commit dd64f24d4c4c8cb763d9fa3aa5a2eb5808b5af9b. * Revert "Change how we detect" This reverts commit ae5607994f30b54158315c72a46583e7cf286fb2. * Revert "Include common module for browser config" This reverts commit bf1815c9b8aaa9091c37d54cf010ff3bd46c8ab4. * Do not import from misc module * Detect how we check if property exists * Do not localize strings * Localize strings using new localize module * Remove outdated comment * Localize 'learn more' text (microsoft/vscode-python#17714) * Update version and change log for point release (microsoft/vscode-python#17717) Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Pavel Minaev <pminaev@microsoft.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Brett Cannon <brcan@microsoft.com> Co-authored-by: Luciana Abud <45497113+luabud@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of empty directories in debugpy wheels when combining them.
Add filename logging when combining wheels.
Update debugpy to 1.5.0.