Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display documentation for auto completion items when addBrackets is true #1659

Merged

Conversation

DonJayamanne
Copy link

Fixes #452

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #1659 into master will increase coverage by 0.11%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
+ Coverage    71.4%   71.52%   +0.11%     
==========================================
  Files         277      277              
  Lines       12985    13021      +36     
  Branches     2334     2346      +12     
==========================================
+ Hits         9272     9313      +41     
+ Misses       3578     3574       -4     
+ Partials      135      134       -1
Impacted Files Coverage Δ
src/client/providers/itemInfoSource.ts 87.09% <100%> (ø) ⬆️
src/client/providers/completionProvider.ts 100% <100%> (ø) ⬆️
src/client/providers/completionSource.ts 95.38% <91.66%> (+2.16%) ⬆️
src/client/debugger/mainV2.ts 75% <0%> (-0.81%) ⬇️
...on/terminal/environmentActivationProviders/bash.ts 91.89% <0%> (-0.71%) ⬇️
src/client/common/terminal/types.ts 100% <0%> (ø) ⬆️
src/client/common/enumUtils.ts 100% <0%> (ø) ⬆️
src/client/extension.ts 96.18% <0%> (+0.08%) ⬆️
src/client/common/terminal/helper.ts 98.7% <0%> (+0.19%) ⬆️
src/client/debugger/Main.ts 52.34% <0%> (+0.49%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4374fe...d91471b. Read the comment docs.

@DonJayamanne DonJayamanne changed the title WIP - Display documentation for auto completion items when addBrackets is true Display documentation for auto completion items when addBrackets is true May 15, 2018
@DonJayamanne DonJayamanne merged commit 67a6a4c into microsoft:master May 21, 2018
@DonJayamanne DonJayamanne deleted the issue452DocsWithAddBrackets branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No docs shown in code completion with python.autoComplete.addBrackets is true
2 participants