Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for evaluating expressions in the experimental debugger #1579

Merged
merged 1 commit into from
May 7, 2018
Merged

Unit tests for evaluating expressions in the experimental debugger #1579

merged 1 commit into from
May 7, 2018

Conversation

DonJayamanne
Copy link

Fixes #1109

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

d3r3kk
d3r3kk reviewed May 2, 2018
View reviewed changes
src/test/debugger/misc.test.ts
debugClient.assertStoppedLocation('breakpoint', breakpointLocation)
]);

//Do not remove this, this is required to ensure PTVSD is ready to accept other requests.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .NET there is a notion of a unit test 'cleanup' method that runs after each unit test method. Aside from the problems that kind of architecture causes (removes the clarity of flow from the unit test a bit) it can be a very useful tool in cases like this where something must run after a test completes.

Does this unit test framework have that available?

Copy link
Author

@DonJayamanne DonJayamanne May 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please look at teardown (towards the top of the file).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I see what's going on then. Some tests require the code you've added in this PR, others do not. There is a 'wait' added after each test to ensure things get back to where they need to be before the next test runs.

Is this a source of test reliability problems in the past?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

d3r3kk
d3r3kk approved these changes May 2, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Please have a look at my comment and let me know if that is something worth pursuing.

@DonJayamanne DonJayamanne merged commit 99b3b84 into microsoft:master May 7, 2018
@DonJayamanne DonJayamanne deleted the issue1109 branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for evaluating expressions in experimental debugger
2 participants
@DonJayamanne @d3r3kk