Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick from main #14644

Merged
merged 5 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actions/build-vsix/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ runs:
- run: npm run updateBuildNumber -- --buildNumber $GITHUB_RUN_ID
shell: bash

- run: npm run addExtensionDependencies
shell: bash

- run: npm run package
shell: bash
26 changes: 26 additions & 0 deletions .github/workflows/insiders.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main

env:
NODE_VERSION: 12.15.0
PYTHON_VERSION: 3.9
MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
# Key for the cache created at the end of the the 'Cache ./pythonFiles/lib/python' step.
Expand All @@ -25,6 +26,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{env.PYTHON_VERSION}}
uses: actions/setup-python@v2
with:
Expand Down Expand Up @@ -55,6 +61,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Install dependencies (npm ci)
run: npm ci --prefer-offline

Expand Down Expand Up @@ -118,6 +129,11 @@ jobs:
with:
path: ${{env.special-working-directory-relative}}

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Install dependencies (npm ci)
run: npm ci

Expand Down Expand Up @@ -319,6 +335,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{matrix.python}}
uses: actions/setup-python@v2
with:
Expand Down Expand Up @@ -390,6 +411,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{matrix.python}}
uses: actions/setup-python@v2
with:
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:

env:
PYTHON_VERSION: 3.8
NODE_VERSION: 12.15.0
MOCHA_REPORTER_JUNIT: false # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it hasn't already.
# Key for the cache created at the end of the the 'Cache ./pythonFiles/lib/python' step.
CACHE_PYTHONFILES: cache-pvsc-pythonFiles
Expand All @@ -27,6 +28,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{env.PYTHON_VERSION}}
uses: actions/setup-python@v2
with:
Expand Down Expand Up @@ -59,6 +65,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Install dependencies (npm ci)
run: npm ci --prefer-offline

Expand Down Expand Up @@ -105,6 +116,11 @@ jobs:
with:
path: ${{env.special-working-directory-relative}}

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Install dependencies (npm ci)
run: npm ci

Expand Down Expand Up @@ -296,6 +312,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{matrix.python}}
uses: actions/setup-python@v2
with:
Expand Down Expand Up @@ -367,6 +388,11 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.2
with:
node-version: ${{env.NODE_VERSION}}

- name: Use Python ${{matrix.python}}
uses: actions/setup-python@v2
with:
Expand Down
1 change: 1 addition & 0 deletions news/1 Enhancements/14614.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update shipped debugger wheels to python 3.8.
2 changes: 1 addition & 1 deletion pythonFiles/install_debugpy.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
EXTENSION_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
DEBUGGER_DEST = os.path.join(EXTENSION_ROOT, "pythonFiles", "lib", "python")
DEBUGGER_PACKAGE = "debugpy"
DEBUGGER_PYTHON_VERSIONS = ("cp37",)
DEBUGGER_PYTHON_VERSIONS = ("cp38",)


def _contains(s, parts=()):
Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/languageClientMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ import { IFileSystem } from '../common/platform/types';
import { IConfigurationService, IDisposableRegistry, IExperimentsManager, IExtensions } from '../common/types';
import { isThenable } from '../common/utils/async';
import { StopWatch } from '../common/utils/stopWatch';
import { NotebookMiddlewareAddon } from '../datascience/languageserver/notebookMiddlewareAddon';
import { IServiceContainer } from '../ioc/types';
import { NotebookMiddlewareAddon } from '../jupyter/languageserver/notebookMiddlewareAddon';
import { sendTelemetryEvent } from '../telemetry';
import { EventName } from '../telemetry/constants';
import { LanguageServerType } from './types';
Expand Down
2 changes: 1 addition & 1 deletion src/client/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ import { Event, Uri } from 'vscode';
import { isTestExecution } from './common/constants';
import { traceError } from './common/logger';
import { IConfigurationService, Resource } from './common/types';
import { IDataViewerDataProvider, IJupyterUriProvider } from './datascience/types';
import { getDebugpyLauncherArgs, getDebugpyPackagePath } from './debugger/extension/adapter/remoteLaunchers';
import { IInterpreterService } from './interpreter/contracts';
import { IServiceContainer, IServiceManager } from './ioc/types';
import { JupyterExtensionIntegration } from './jupyter/jupyterIntegration';
import { IDataViewerDataProvider, IJupyterUriProvider } from './jupyter/types';

/*
* Do not introduce any breaking changes to this API.
Expand Down
142 changes: 0 additions & 142 deletions src/client/datascience/api/jupyterIntegration.ts

This file was deleted.

2 changes: 1 addition & 1 deletion src/client/jupyter/jupyterIntegration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ import {
Resource
} from '../common/types';
import { isResource } from '../common/utils/misc';
import { IDataViewerDataProvider, IJupyterUriProvider } from '../datascience/types';
import { getDebugpyPackagePath } from '../debugger/extension/adapter/remoteLaunchers';
import { IEnvironmentActivationService } from '../interpreter/activation/types';
import { IInterpreterQuickPickItem, IInterpreterSelector } from '../interpreter/configuration/types';
import { IInterpreterService } from '../interpreter/contracts';
import { IWindowsStoreInterpreter } from '../interpreter/locators/types';
import { WindowsStoreInterpreter } from '../pythonEnvironments/discovery/locators/services/windowsStoreInterpreter';
import { PythonEnvironment } from '../pythonEnvironments/info';
import { IDataViewerDataProvider, IJupyterUriProvider } from './types';

export interface ILanguageServer extends Disposable {
readonly connection: ILanguageServerConnection;
Expand Down
File renamed without changes.
29 changes: 0 additions & 29 deletions src/test/datascience/mockJupyterExtensionIntegration.ts

This file was deleted.