Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More of the functional tests are failing #14346

Merged
merged 25 commits into from
Oct 10, 2020
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Oct 9, 2020

Fix the last remaing flakey tests. I have full GREEN! I deserve a beer or something now.

Raw kernel interrupt test looks like it's because the kernel dies before the code starts actually running (I think the kernel interrupt was too soon?) A small sleep seems to fix it.

Export/Import test fails on test machine was because we were deleting all temp .ipynb files after after test run. This seems to have fixed a bunch more flakey issues.

The trusted notebook test I couldn't get to repro and adding logging fixed it. I added a sleep and it seems to work now.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@rchiodo rchiodo added the no-changelog No news entry required label Oct 9, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo marked this pull request as ready for review October 10, 2020 00:06
@@ -500,18 +497,6 @@ export class DataScienceIocContainer extends UnitTestIocContainer {
// Make sure to disable all command handling during dispose. Don't want
// anything to startup again.
this.commandManager.dispose();
try {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was causing all sorts of random failures.

Copy link

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉 🍺

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@842a0b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14346   +/-   ##
=======================================
  Coverage        ?   59.42%           
=======================================
  Files           ?      716           
  Lines           ?    39952           
  Branches        ?     5789           
=======================================
  Hits            ?    23740           
  Misses          ?    14951           
  Partials        ?     1261           
Impacted Files Coverage Δ
src/client/formatters/blackFormatter.ts 79.16% <0.00%> (ø)
src/client/linters/errorHandlers/standard.ts 31.81% <0.00%> (ø)
src/client/providers/symbolProvider.ts 88.73% <0.00%> (ø)
src/datascience-ui/common/cellFactory.ts 34.14% <0.00%> (ø)
...interpreter/jupyterInterpreterDependencyService.ts 76.57% <0.00%> (ø)
src/client/common/application/types.ts 100.00% <0.00%> (ø)
src/datascience-ui/renderers/constants.ts 0.00% <0.00%> (ø)
src/client/pythonEnvironments/info/interpreter.ts 80.95% <0.00%> (ø)
src/client/common/installer/poetryInstaller.ts 95.83% <0.00%> (ø)
src/client/activation/jedi/languageServerProxy.ts 27.27% <0.00%> (ø)
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842a0b3...f1765f9. Read the comment docs.

@rchiodo rchiodo merged commit 74253ef into main Oct 10, 2020
@rchiodo rchiodo deleted the rchiodo/more_flake_failures branch October 10, 2020 00:35
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
* Splitting test log

* Fix problem with kernels ports being reused

* Make kernel launcher port round robin only for testing

* Make formatters change only apply during testing

* Add news entry

* Apply black formatting

* Code review feedback and skip flakey remote password test

* Another flakey test

* More CR feedback

* Missed a spot

* Some more log parser changes and try to get interrupt to be less flakey

* Fix interrupt killing kernel and add more logging for export

* More logging

* See if updating fixes the problem

* Dont delete temp files

* Upload webview output to figure out trust failure

* Add name to step

* Try another way to upload

* Upload doesn't seem to work

* Try a different way to upload

* Try without webview logging as this makes the test pass

* Try fixing test another way. Any logging is making the test pass

* Compile error
DonJayamanne pushed a commit that referenced this pull request Oct 30, 2020
* Fix two problems with escaping (#14228)

* Remove unneeded cell keys when exporting (#14241)

* Remove transient output when exporting from the interactive window

* Add news entry

* Test was failing with true jupyter (#14261)

* Potential fix for ipywidget flakiness (#14281)

* Try running tests with space in root path (#14113)

* Add test with a space (only works on flake)

* Push to insiders.yml only

* Remove test that doesn't really do anything

* REmove unused bits

* Change path to have unicode too

* Get test to run

* Set root path differently

* Valid dir

* A different way

* Another way

* Try creating the directory first

* Another try

* Only one env

* Pass parameters correctly

* Try without unicode

* Set working directory directly on xvfb actions

* Working-directory not workingDirectory

* Cached ts files output

* Remove test with space branch for insiders

* Update vscode-python-pr-validation.yaml (#14285)

REmove missing branch? Might make it work again

* Get rid of AZDO yamls. Not used anymore

* Dont run on push (#14307)

* Fix random failures on functional tests (#14331)

* Splitting test log

* Fix problem with kernels ports being reused

* Make kernel launcher port round robin only for testing

* Make formatters change only apply during testing

* Add news entry

* Apply black formatting

* Code review feedback and skip flakey remote password test

* Another flakey test

* More CR feedback

* Missed a spot

* More of the functional tests are failing (#14346)

* Splitting test log

* Fix problem with kernels ports being reused

* Make kernel launcher port round robin only for testing

* Make formatters change only apply during testing

* Add news entry

* Apply black formatting

* Code review feedback and skip flakey remote password test

* Another flakey test

* More CR feedback

* Missed a spot

* Some more log parser changes and try to get interrupt to be less flakey

* Fix interrupt killing kernel and add more logging for export

* More logging

* See if updating fixes the problem

* Dont delete temp files

* Upload webview output to figure out trust failure

* Add name to step

* Try another way to upload

* Upload doesn't seem to work

* Try a different way to upload

* Try without webview logging as this makes the test pass

* Try fixing test another way. Any logging is making the test pass

* Compile error

* Add more logging to figure out why raw kernel did not start (#14374)

* Some more logging

* Some more logging

* Move PR changes into pr.yml

* Fix multiprocessing problems with setting __file__ (#14376)

* Fix multiprocessing problems with setting __file__

* Update news entry

* Problem with wait for idle not propagating outwards

* Fix unnecessary ask for python extension install

* Don't error on warning for kernel install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants