Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running tests with space in root path #14113

Merged
merged 20 commits into from
Oct 6, 2020
Merged

Try running tests with space in root path #14113

Changes from 4 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
66874f6
Add test with a space (only works on flake)
rchiodo Sep 25, 2020
6a87365
Push to insiders.yml only
rchiodo Sep 25, 2020
e0f68c0
Remove test that doesn't really do anything
rchiodo Sep 25, 2020
98134f3
REmove unused bits
rchiodo Sep 25, 2020
eb7e1db
Change path to have unicode too
rchiodo Sep 28, 2020
3cc5127
Get test to run
rchiodo Sep 28, 2020
315ba13
Set root path differently
rchiodo Sep 28, 2020
3e82acc
Valid dir
rchiodo Sep 28, 2020
2cb4885
A different way
rchiodo Sep 28, 2020
d66ec81
Another way
rchiodo Sep 28, 2020
94a0d04
Try creating the directory first
rchiodo Sep 28, 2020
1716099
Another try
rchiodo Sep 28, 2020
b080db9
Only one env
rchiodo Sep 28, 2020
3c4bc0a
Pass parameters correctly
rchiodo Sep 28, 2020
3e9a19e
Try without unicode
rchiodo Sep 28, 2020
70b7c31
Set working directory directly on xvfb actions
rchiodo Sep 28, 2020
46584e9
Working-directory not workingDirectory
rchiodo Sep 28, 2020
7fd5715
Cached ts files output
rchiodo Sep 29, 2020
b0be9dc
Merge remote-tracking branch 'origin/main' into rchiodo/test_with_space
rchiodo Oct 6, 2020
47c6c9c
Remove test with space branch for insiders
rchiodo Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/insiders.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
path: 'source path'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path: 'source path'
path: 'path with a space in it'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would some Unicode be worth it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good idea. I'll add a unicode character and a space

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to open issues for the 2.7 test failures when using Unicode characters?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd say so. Unless we don't care about supporting 2.7 with people with unicode characters in their paths?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we aren't quite ready to drop 2.7 support, so if there's a Unicode issue there then we should fix them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll take care of opening Unicode issues.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta issue for all Unicode-related failures in for the test job of the Insiders workflow: #14292


- name: Cache pip files
uses: actions/cache@v2
Expand Down