Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All languages in native notebooks, default Python #13786

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

DonJayamanne
Copy link

For #13484
Temporarily defaults to Python, later we'll support defaulting to other languages based on notebooks used by user https://github.com/microsoft/vscode-python/issues/13522

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #13786 into main will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13786      +/-   ##
==========================================
+ Coverage   59.88%   59.91%   +0.03%     
==========================================
  Files         678      684       +6     
  Lines       37867    37956      +89     
  Branches     5458     5464       +6     
==========================================
+ Hits        22675    22740      +65     
- Misses      14034    14039       +5     
- Partials     1158     1177      +19     
Impacted Files Coverage Δ
src/client/datascience/notebook/helpers/helpers.ts 39.34% <33.33%> (-0.08%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/platform.ts 56.00% <0.00%> (-8.00%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 62.74% <0.00%> (ø)
src/client/logging/formatters.ts 53.57% <0.00%> (ø)
src/client/logging/transports.ts 65.11% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ab698...29bde45. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DonJayamanne DonJayamanne merged commit 49f160a into microsoft:main Sep 4, 2020
@DonJayamanne DonJayamanne deleted the supportAllLanguages branch September 4, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants