Fix #13218: Add "pythonArgs" debug property to launch.json schema #13219
Conversation
package.json
Outdated
| @@ -1439,6 +1439,14 @@ | |||
| "description": "Path (fully qualified) to python executable. Defaults to the value in settings", | |||
| "default": "${command:python.interpreterPath}" | |||
| }, | |||
| "pythonArgs": { | |||
| "type": "array", | |||
| "description": "Command-line arguments passed to the Python interpreter.", | |||
There was a problem hiding this comment.
@luabud Please check the wording. I wasn't sure what the most appropriate term to use here, because "pythonPath" description says "executable", but then we seem to be using "interpreter" elsewhere a lot - more consistently so in more recent additions to the extension.
There was a problem hiding this comment.
Looks great to me, I've talked to @brettcannon about this and I think he's okay with us using interpreter in this case.
There was a problem hiding this comment.
I think we need to add "Use args to pass arguments to your script or module". Because i read the above as this is the way to pass arguments.
There was a problem hiding this comment.
Keep in mind that they'll see "args" in the list first, long before they get to this one. I don't think it's very likely that someone will get confused by the tooltip alone... and we always have docs for the detailed descriptions.
There was a problem hiding this comment.
@luabud I can also edit the description for "pythonPath" to be consistent. :)
Codecov Report
@@ Coverage Diff @@
## master #13219 +/- ##
==========================================
- Coverage 59.63% 59.61% -0.03%
==========================================
Files 670 670
Lines 36823 36823
Branches 5188 5188
==========================================
- Hits 21960 21951 -9
- Misses 13770 13776 +6
- Partials 1093 1096 +3
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
For #13218
Appropriate comments and documentation strings in the code.Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.