Fix #12595: Opt out of process tree compacting #12698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int19h
commented
Jul 1, 2020
| const launched = await this.debugService.startDebugging(folder, debugConfig, { | ||
| parentSession, | ||
| noCompact: true | ||
| } as DebugSessionOptions); |
There was a problem hiding this comment.
This was necessary to test this change, because "noCompact" is currently a VSCode proposed API. It needs to be removed prior to merging, once the flag migrates to stable API.
Change IDebugService.startDebugging() to use DebugSessionOptions.
Use {noCompact: true} option for child sessions.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Not needed anymore - VSCode changed this to opt-in rather than opt-out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change IDebugService.startDebugging() to use DebugSessionOptions.
Use {noCompact: true} option for child sessions.
For #12595
Has a news entry file (remember to thank yourself!).Appropriate comments and documentation strings in the code.Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.