Added diagnostic asking users to delete pythonPath from their workspace settings #11113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11113 +/- ##
==========================================
- Coverage 61.27% 60.52% -0.75%
==========================================
Files 593 598 +5
Lines 32492 34878 +2386
Branches 4593 5214 +621
==========================================
+ Hits 19910 21111 +1201
- Misses 11580 12713 +1133
- Partials 1002 1054 +52
Continue to review full report at Codecov.
|
src/client/application/diagnostics/checks/pythonPathDeprecated.ts
Outdated
Show resolved
Hide resolved
src/client/application/diagnostics/checks/pythonPathDeprecated.ts
Outdated
Show resolved
Hide resolved
src/client/application/diagnostics/checks/pythonPathDeprecated.ts
Outdated
Show resolved
Hide resolved
| @@ -335,7 +338,7 @@ | |||
| "DataScience.valuesColumn": "values", | |||
| "DataScience.liveShareInvalid": "One or more guests in the session do not have the Python [extension](https://marketplace.visualstudio.com/itemdetails?itemName=ms-python.python) installed.\r\nYour Live Share session cannot continue and will be closed.", | |||
| "diagnostics.updateSettings": "Yes, update settings", | |||
| "Common.noIWillDoItLater": "No, I will do it later", | |||
| "Common.noIWillDoItLater": "No, I'll do it later", | |||
There was a problem hiding this comment.
To decrease the size of the button in the prompt.
There was a problem hiding this comment.
This would only work in English, and not other languages.
There was a problem hiding this comment.
I would say let's try to solve this where we can, removing all translations doesn't seem right.
Also, on second thought, I don't think translation from I will to I'll will affect translation to other languages.
There was a problem hiding this comment.
I would say let's try to solve this where we can
I disagree. And it's not removing all translations, I disagree with the contraction here.
I don't think translation from I will to I'll will affect translation to other languages.
Exactly, it's an English-centric approach that doesn't take into account the other languages. The prompt buttons may look balanced in English, but German users (and probably others) will still see a button that's too big.
There was a problem hiding this comment.
it's an English-centric approach that doesn't take into account the other languages
Why does it need to take into account the other languages, when changing I will to I'll in English doesn't affect translations in other languages?
If I am changing the string No I will do it later to something else which changes its translation to other languages, I can see that I am solving it just for English which is wrong, but that's not the case.
karrtikr
requested review from
ericsnowcurrently
and removed request for
ericsnowcurrently
|
Builds passing on CI but not showing up here😩
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closed in favor of #11180 |
Closed in favor of #11180
For #11108
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).