Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hatch environment discovery #22810

Closed
flying-sheep opened this issue Jan 30, 2024 · 0 comments · Fixed by #22779
Closed

Add Hatch environment discovery #22810

flying-sheep opened this issue Jan 30, 2024 · 0 comments · Fixed by #22779
Assignees
@flying-sheep
Labels
area-environments Features relating to handling interpreter environments community ask Feature request that the community expressed interest in feature-request Request for new features or functionality needs PR Ready to be worked on on-testplan Added to test plan
Milestone
March 2024

Comments

@flying-sheep
Copy link

We already support Poetry, and a environment management PEP isn’t even in the works AFAIK.

Hatch is pretty popular (e.g. it’s used by all of the jupyter ecosystem), but its environments aren’t found by VS Code Python yet (unless Hatch is configured to create them in the project directory)
@flying-sheep flying-sheep added the feature-request Request for new features or functionality label Jan 30, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 30, 2024
@flying-sheep flying-sheep mentioned this issue Jan 30, 2024
Merged
3 tasks
@anthonykim1 anthonykim1 added community ask Feature request that the community expressed interest in needs PR Ready to be worked on area-environments Features relating to handling interpreter environments and removed triage-needed Needs assignment to the proper sub-team labels Jan 30, 2024
@karrtikr karrtikr assigned flying-sheep and unassigned karrtikr Feb 1, 2024
@karrtikr karrtikr added this to the March 2024 milestone Mar 15, 2024
karrtikr pushed a commit that referenced this issue Mar 15, 2024
@flying-sheep
Add support for Hatch environments (#22779)
cd3ea27 
Fixes #22810

TODO

- [x] check if it actually works already or if more things need to be
registered
- [x] add config val
- [x] add tests
@karrtikr karrtikr mentioned this issue Mar 16, 2024
Merged
karrtikr pushed a commit that referenced this issue Mar 17, 2024
If type identifier for an environment is not registered, infer type f…
62dc85b 
…rom locator (#23083)

For #22810

...so in case of Hatch, as an [explicit Hatch identifier is not
available](#22779 (comment)),
we infer an environment is Hatch if we get it from the Hatch locator:
#22779.
@karrtikr karrtikr mentioned this issue Mar 18, 2024
Closed
3 tasks
@karrtikr karrtikr added the on-testplan Added to test plan label Mar 18, 2024
@kieferrm kieferrm mentioned this issue Mar 18, 2024
Closed
36 tasks
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 5, 2024
@flying-sheep
Add support for Hatch environments (microsoft/vscode-python#22779)
c03cd44 
Fixes microsoft/vscode-python#22810

TODO

- [x] check if it actually works already or if more things need to be
registered
- [x] add config val
- [x] add tests
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 5, 2024
If type identifier for an environment is not registered, infer type f…
62beb8c 
…rom locator (microsoft/vscode-python#23083)

For microsoft/vscode-python#22810

...so in case of Hatch, as an [explicit Hatch identifier is not
available](microsoft/vscode-python#22779 (comment)),
we infer an environment is Hatch if we get it from the Hatch locator:
microsoft/vscode-python#22779.
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 8, 2024
@flying-sheep @wesm
Add support for Hatch environments (microsoft/vscode-python#22779)
3ba069f 
Fixes microsoft/vscode-python#22810

TODO

- [x] check if it actually works already or if more things need to be
registered
- [x] add config val
- [x] add tests
wesm pushed a commit to posit-dev/positron that referenced this issue Apr 8, 2024
@wesm
If type identifier for an environment is not registered, infer type f…
6b377d9 
…rom locator (microsoft/vscode-python#23083)

For microsoft/vscode-python#22810

...so in case of Hatch, as an [explicit Hatch identifier is not
available](microsoft/vscode-python#22779 (comment)),
we infer an environment is Hatch if we get it from the Hatch locator:
microsoft/vscode-python#22779.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flying-sheep flying-sheep

Labels
area-environments Features relating to handling interpreter environments community ask Feature request that the community expressed interest in feature-request Request for new features or functionality needs PR Ready to be worked on on-testplan Added to test plan
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

Add support for Hatch environments flying-sheep/vscode-python
3 participants
@flying-sheep @karrtikr @anthonykim1