Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlled rollout of notifying about the black/pylint/isort extension. #19653

Closed
5 tasks done
karthiknadig opened this issue Aug 8, 2022 · 3 comments
Closed
5 tasks done
Assignees
Labels
area-formatting area-linting author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Aug 8, 2022

  • Add new experiment in the control tower @luabud
  • Add prompt to asking users to switch to using the new extensions.
    • isort : We decided to replace the isort shipped with the extension to just use isort extension.
    • black/autopep8 : We have to prompt users for each selected formatter.
    • pylint/flake8 : We have to prompt users for each selected linter.
@karthiknadig karthiknadig added this to the August 2022 milestone Aug 8, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 8, 2022
@karthiknadig karthiknadig added feature-request Request for new features or functionality area-linting needs PR area-formatting and removed triage-needed Needs assignment to the proper sub-team labels Aug 9, 2022
@karthiknadig karthiknadig changed the title Control rollout of notifying about the black/pylint/isort extension. Controlled rollout of notifying about the black/pylint/isort extension. Aug 9, 2022
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karthiknadig
Copy link
Member Author

karthiknadig commented Aug 12, 2022

@luabud How does this look like for the transition to extension?

flowchart TD
    start([start])
    finished([end])

    is_linter_enabled{Is Linter Enabled?}
    has_args{Has Linter args?}
    are_simple_args{Are simple args?}
    install_extensions{Install extensions?}

    show_prompt[Show prompt]
    no_prompt[No prompt]

    trigger_install[trigger install]
    copy_args[Copy arguments]

    start --> is_linter_enabled

    is_linter_enabled -- yes --> has_args
    is_linter_enabled -- no --> no_prompt

    has_args -- yes --> are_simple_args
    has_args -- no --> show_prompt 

    are_simple_args -- yes --> show_prompt
    are_simple_args -- no --> no_prompt

    show_prompt --> install_extensions 

    install_extensions -- no --> finished
    install_extensions -- yes --> trigger_install

    trigger_install --> copy_args

    copy_args --> finished
    no_prompt --> finished
Loading

@luabud
Copy link
Member

luabud commented Aug 12, 2022

This looks good to me! If users don't have args, wouldn't we want to transition them to the new extensions as well?

@karthiknadig
Copy link
Member Author

@luabud Can you verify this when you get the chance for Formatting prompt?

@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Mar 20, 2023
@rebornix rebornix added the verification-steps-needed Steps to verify are needed for verification label Mar 22, 2023
@luabud luabud added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Mar 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting area-linting author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants