Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in extension path: Make testing part of insiders.yml/release.yml #14168

Closed
rchiodo opened this issue Sep 29, 2020 · 3 comments
Closed

Space in extension path: Make testing part of insiders.yml/release.yml #14168

rchiodo opened this issue Sep 29, 2020 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug meta Issue that is tracking an overall project

Comments

@rchiodo
Copy link

rchiodo commented Sep 29, 2020

After all of these issues are fixed:
#14163
#14164
#14165
#14166
#14167

Submit this pr here (after modifying it to not run on that specific branch):
#14113

@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority triage-needed Needs assignment to the proper sub-team labels Sep 29, 2020
@brettcannon brettcannon added the meta Issue that is tracking an overall project label Sep 29, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 29, 2020
@kimadeline
Copy link

@rchiodo Do we need a separate PR for release.yml, or can we consider this done?

@rchiodo
Copy link
Author

rchiodo commented Oct 7, 2020

I guess that's open for discussion? I think insiders testing of spaces is probably good enough. It should catch any errors before they get into the release branch. So I'd say this is done. But if you guys want to double check the release branch too, feel free to copy the changes to the release.yml.

@kimadeline kimadeline added needs PR and removed important Issue identified as high-priority labels Oct 7, 2020
@kimadeline
Copy link

kimadeline commented Oct 7, 2020

Eventually we should also make sure the release branch also runs tests with spaces in the extension path, but we're not going to address it right now 👉 Leaving the issue open but removing the P1 label.

Update: we're going to deal with it now, and make similar changes to the release workflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug meta Issue that is tracking an overall project
Projects
None yet
Development

No branches or pull requests

3 participants